-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The last successful screenshot should be from the same location #330
Labels
bug
Something isn't working
Comments
This was referenced Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a step fails and we show the screenshot of the last successful check as a comparison to the failure, it does so using the screenshot of the most recent successful test prior to the failure.
However, when tests for the same monitor are running from multiple locations, the screenshot we show will be the most recent (prior to the failure) regardless of location.
It’s not uncommon for websites to deliver different content based on the location of the client. As such, the most recent good image (for comparison) should only be shown from test results from the same location.
In fact, if there are no previous good tests from this location, then no comparison image should be shown (even if there is a good test from a different location), as it’s a misleading comparison.
The text was updated successfully, but these errors were encountered: