Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration Page does not allow form submission with Enter key unless focused on Submit button #520

Closed
plundaahl-ep opened this issue Dec 3, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@plundaahl-ep
Copy link
Contributor

Step 1: Are you in the right place?

Yes (this is a Reference Store UI issue).

Step 2: Describe your environment

This was observed on a copy of Reference Store that was hosted on AWS S3, compiled with the Node version mentioned below

  • Device: Macbook Pro (15-inc, 2018)
  • OS version: OSX Version 10.14.6 (18G103)
  • Storefront pulled version: v3.0.12 (commit fc249c8)
  • Node version: v11.15.0
  • (Docker versions omitted as Docker is not involved in this deployment).

Step 3: Describe the problem:

On the Registration page, pressing the enter key while focused on the input text boxes does not submit the form. Instead, users need to first tab to the submit button. I think this breaks standard keyboard navigation conventions.

In vanilla HTML/JS forms, pressing enter while focused anywhere within a <form></form> tag pair that contains a <button type="submit"> button will trigger a form submit.

Note: This is not an issue in every form in the Reference Store - most of them behave exactly as expected. I think most likely the registration form just got missed.

Steps to reproduce:

  1. Ensure you are not logged in
  2. Click "Login"
  3. Click "Register"
  4. Fill out the form fields
  5. While focused on one of the text inputs (not the submit button), press enter

Observed Results:

  • Pressing the enter key while focused on any form element except the "Submit" button does nothing.

Expected Results:

  • While focused within a form, pressing the enter key from anywhere within that form should trigger the submit functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants