Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl transport host_unreachable_exceptions should potentially include more errors #55

Closed
mikebaldry opened this issue Apr 17, 2014 · 5 comments

Comments

@mikebaldry
Copy link
Contributor

We sometimes see these 2 errors pop up:
Curl::Err::GotNothingError
Curl::Err::RecvError

It would be great to retry them as they don't happen for any particular reason I can see and its very temporary.

@karmi
Copy link
Contributor

karmi commented Apr 17, 2014

So, what should we do, add it to Elasticsearch::Transport::Transport::HTTP::Curb::host_unreachable_exceptions?

@mikebaldry
Copy link
Contributor Author

Yeah, I see a Curl::Err::SendError once in a while too that could be retried.

I was just more putting the idea out there. I don't know if there is a reason why not to retry these?

If you're happy, I'll PR.

@karmi
Copy link
Contributor

karmi commented Apr 17, 2014

I don't remember seeing these with Curb, on the other hand, they look like safe ones to retry, so I think you can just send the PR with these added...

@mikebaldry
Copy link
Contributor Author

Ok cheers

@karmi
Copy link
Contributor

karmi commented Jun 25, 2014

Michael, finally merged this, sorry for the holdup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants