External method to set rootTypeParsers in DocumentMapperParser incorrect

[karol-gwaj]

looks like there is small bug in putRootTypeParser method in DocumentMapperParser class:

method:

    public void putRootTypeParser(String type, Mapper.TypeParser typeParser) {
        synchronized (typeParsersMutex) {
            rootTypeParsers = new MapBuilder<String, Mapper.TypeParser>()
                    .putAll(typeParsers)
                    .put(type, typeParser)
                    .immutableMap();
        }
    }

should look more like this:

    public void putRootTypeParser(String type, Mapper.TypeParser typeParser) {
        synchronized (typeParsersMutex) {
            rootTypeParsers = new MapBuilder<String, Mapper.TypeParser>(rootTypeParsers)
                    .put(type, typeParser)
                    .immutableMap();
        }
    }

current version when called will override root type parsers with type parsers

[kimchy]

indeed, its a bug. this method is mainly aimed at external plugins using it, is that what you are trying to use it for?

[karol-gwaj]

kinda, im planning to use putTypeParser method in my plugin
simply i accidentally eyeballed this method too (as they are close to each other in the class)