starting elasticsearch on solaris fails (1.0.0.Beta2-SNAPSHOT)

[ah85]

When executing bin/elasticsearch on solaris, I got this error:

./elasticsearch: syntax error at line 92: `JAVA=$' unexpected

Had to change this line:
JAVA=$(which java)
to:
JAVA=which java``

This also makes it consistent with the rest of the file.

Version: 1.0.0.Beta2-SNAPSHOT

[spinscale]

Thanks a lot for notifying! Took the opportunity and removed any $(whatever) bashism by using backticks.

[tmzullinger]

FWIW, $() is not a bashism. It is defined in POSIX¹. If /bin/sh on Solaris doesn't accept this, it's because it's an ancient shell (not surprising, given how ancient most of the tools on Solaris are).

That might still be a reason to use backticks, but it's incorrect to call this a bashism. When working around old shells on systems like Solaris, it's worth noting that's the problem so the work around can be removed when those ancient systems are no longer supported. (As I understand it, even Solaris has a proper posix sh, it just isn't always /bin/sh.)

¹ http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_06_03