Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup aggs java api #4922

Closed
uboness opened this issue Jan 28, 2014 · 0 comments
Closed

Cleanup aggs java api #4922

uboness opened this issue Jan 28, 2014 · 0 comments
Labels
>enhancement v1.0.0.RC2 v1.1.0 v2.0.0-beta1

Comments

@uboness
Copy link
Contributor

uboness commented Jan 28, 2014

  • add javadocs
  • remove Iterable from all multi-bucket aggregations
  • all single-bucket aggregations should have getDocCount() and getAggregations()
  • all multi-bucket aggregations should have getBuckets() that returns Collection
  • every multi-bucket aggregation should have these methods:
    • getBuckets() : Collection
    • getBucketByKey(String) : Bucket
    • getBucketByKey(Number) : Bucket (only for numeric buckets)
    • getBucketByKey(DateTime) : Bucket (only for date buckets)
    • getBucketByKey(GeoPoint) : Bucket (only for geohash buckets)
  • every bucket in all multi-bucket aggregations should have these methods:
    • getKey() : String
    • getKeyAsText() : Text
    • getKeyAsNumber() : Number (if the key can be numeric value, eg. range & histograms)
    • getKeyAsGeoPoint() : GeoPoint (in case of the geohash_grid agg)
uboness added a commit that referenced this issue Jan 28, 2014
@uboness
cleanup of aggregations api
f77ce10 
- add javadocs
- remove Iterable from all multi-bucket aggregations
- all single-bucket aggregations should have getDocCount() and getAggregations()
- all multi-bucket aggregations should have getBuckets() that returns Collection
- every multi-bucket aggregation should have these methods:
 - getBuckets() : Collection
 - getBucketByKey(String) : Bucket
 - getBucketByKey(Number) : Bucket (only for numeric buckets)
 - getBucketByKey(DateTime) : Bucket (only for date buckets)
 - getBucketByKey(GeoPoint) : Bucket (only for geohash_grid)
- every bucket in all multi-bucket aggregations should have these methods:
 - getKey() : String
 - getKeyAsText() : Text
 - getKeyAsNumber() : Number (if the key can be numeric value, eg. range & histograms)
 - getKeyAsGeoPoint() : GeoPoint (in case of the geohash_grid agg)

 Closes #4922
uboness added a commit that referenced this issue Jan 28, 2014
@uboness
cleanup of aggregations api
a5298ef 
- add javadocs
- remove Iterable from all multi-bucket aggregations
- all single-bucket aggregations should have getDocCount() and getAggregations()
- all multi-bucket aggregations should have getBuckets() that returns Collection
- every multi-bucket aggregation should have these methods:
 - getBuckets() : Collection
 - getBucketByKey(String) : Bucket
 - getBucketByKey(Number) : Bucket (only for numeric buckets)
 - getBucketByKey(DateTime) : Bucket (only for date buckets)
 - getBucketByKey(GeoPoint) : Bucket (only for geohash_grid)
- every bucket in all multi-bucket aggregations should have these methods:
 - getKey() : String
 - getKeyAsText() : Text
 - getKeyAsNumber() : Number (if the key can be numeric value, eg. range & histograms)
 - getKeyAsGeoPoint() : GeoPoint (in case of the geohash_grid agg)

 Closes #4922
@uboness uboness mentioned this issue Jan 28, 2014
Closed
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@uboness
cleanup of aggregations api
a4b9edd 
- add javadocs
- remove Iterable from all multi-bucket aggregations
- all single-bucket aggregations should have getDocCount() and getAggregations()
- all multi-bucket aggregations should have getBuckets() that returns Collection
- every multi-bucket aggregation should have these methods:
 - getBuckets() : Collection
 - getBucketByKey(String) : Bucket
 - getBucketByKey(Number) : Bucket (only for numeric buckets)
 - getBucketByKey(DateTime) : Bucket (only for date buckets)
 - getBucketByKey(GeoPoint) : Bucket (only for geohash_grid)
- every bucket in all multi-bucket aggregations should have these methods:
 - getKey() : String
 - getKeyAsText() : Text
 - getKeyAsNumber() : Number (if the key can be numeric value, eg. range & histograms)
 - getKeyAsGeoPoint() : GeoPoint (in case of the geohash_grid agg)

 Closes elastic#4922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement v1.0.0.RC2 v1.1.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cleanup of aggregations api
1 participant
@uboness