You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Today when we start a TransportClient we use the given transport addresses and create a DiscoveryNode from it without knowing the actual nodes version. We just use the Version.CURRENT which is an upper bound. Yet, the other node might be a version less than the currently running and serialisation of the nodes info might break. We should rather use a lower bound here which is the version of the first release with the same major version as Version.CURRENT since this is what we officially support.
We changed the format of the NodesInfo serialisation today and BWC tests broken on that. Yet we found a away to work around changing it but in the future we should be able to change transport protocol even if it's NodesInfo
Note: this is not a problem until today but in the future this might prevent us from enhancing the protocol here.
The text was updated successfully, but these errors were encountered:
Today when we start a `TransportClient` we use the given transport
addresses and create a `DiscoveryNode` from it without knowing the
actual nodes version. We just use the `Version.CURRENT` which is an
upper bound. Yet, the other node might be a version less than the
currently running and serialisation of the nodes info might break. We
should rather use a lower bound here which is the version of the first
release with the same major version as `Version.CURRENT` since this is
what we officially support.
This commit moves to use the minimum major version or an RC / Snapshot
if the current version is a snapshot.
Closeselastic#6894
Today when we start a `TransportClient` we use the given transport
addresses and create a `DiscoveryNode` from it without knowing the
actual nodes version. We just use the `Version.CURRENT` which is an
upper bound. Yet, the other node might be a version less than the
currently running and serialisation of the nodes info might break. We
should rather use a lower bound here which is the version of the first
release with the same major version as `Version.CURRENT` since this is
what we officially support.
This commit moves to use the minimum major version or an RC / Snapshot
if the current version is a snapshot.
Closes#6894
Today when we start a
TransportClient
we use the given transport addresses and create aDiscoveryNode
from it without knowing the actual nodes version. We just use theVersion.CURRENT
which is an upper bound. Yet, the other node might be a version less than the currently running and serialisation of the nodes info might break. We should rather use a lower bound here which is the version of the first release with the same major version asVersion.CURRENT
since this is what we officially support.We changed the format of the
NodesInfo
serialisation today and BWC tests broken on that. Yet we found a away to work around changing it but in the future we should be able to change transport protocol even if it'sNodesInfo
Note: this is not a problem until today but in the future this might prevent us from enhancing the protocol here.
The text was updated successfully, but these errors were encountered: