RestAPI: Change validation exceptions to respond with 400 status instead of 500 #7619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of 500. Validation errors are clearly in the realm of client errors (a program with the request). Thus they should return a 4xx response code.
|
to me that is the right thing to do - @clintongormley what do you think? we should return 400 instead of 500 in the case the request doesn't validate? |
|
LGTM |
1 similar comment
|
LGTM |
rjernst
added a commit
that referenced
this pull request
Sep 7, 2014
…ead of 500. Validation errors are clearly in the realm of client errors (a program with the request). Thus they should return a 4xx response code. closes #7619
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation errors are clearly in the realm of client errors (a program with the request). Thus they should return a 4xx response code.