Support for artificial documents in MLT query #7725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexksikes
added
v1.5.0
review
v2.0.0-beta1
>feature
>enhancement
v1.4.0.Beta1
and removed
v1.5.0
labels
| @@ -95,11 +95,11 @@ public static Uid createUid(String uid) { | |||
| return new Uid(uid.substring(0, delimiterIndex), uid.substring(delimiterIndex + 1)); | |||
| } | |||
|
|
|||
| public static BytesRef[] createUids(List<MultiGetRequest.Item> items) { | |||
| BytesRef[] uids = new BytesRef[items.size()]; | |||
| public static BytesRef[] createUids(List<TermVectorRequest> requests) { | |||
There was a problem hiding this comment.
we have a new interface called DocumentRequest that is more generic and I just checked that TermVectorRequest implements all the methods already. I think we should do that and make this List<DocumentRequest>
There was a problem hiding this comment.
Perfect! Thanks.
|
I left some minor comments looks good in general |
Previously, the only way to specify a document not present in the index was to use `like_text`. This would usually lead to complex queries made of multiple MLT queries per document field. This commit adds the ability to the MLT query to directly specify documents not present in the index (artificial documents). The syntax is similar to the Percolator API or to the Multi Term Vector API.
alexksikes
force-pushed
the
feature/mlt-docs
branch
from
ac6a6a8
to
b5043ca
Compare
|
LGTM thanks alex!!! |
alexksikes
added a commit
that referenced
this pull request
Sep 29, 2014
Previously, the only way to specify a document not present in the index was to use `like_text`. This would usually lead to complex queries made of multiple MLT queries per document field. This commit adds the ability to the MLT query to directly specify documents not present in the index (artificial documents). The syntax is similar to the Percolator API or to the Multi Term Vector API. Closes #7725
16 tasks
clintongormley
changed the title
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the only way to specify a document not present in the index was to
use
like_text. This would usually lead to complex queries made of multipleMLT queries per document field. This commit adds the ability to the MLT query
to directly specify documents not present in the index (artificial documents).
The syntax is similar to the Percolator API or to the Multi Term Vector API.