Restore of indices that are only partially available in the cluster #8341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imotov
added
:Distributed/Snapshot/Restore
| if (logger.isDebugEnabled()) { | ||
| logger.debug("[{}][{}]: not allocating, number_of_allocated_shards_found [{}], required_number [{}]", shard.index(), shard.id(), numberOfAllocationsFound, requiredAllocation); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
can this be else if saves a line or two
|
left a cosmetic comment LGTM otherwise |
…e in the cluster Fixes the issue with restoring of an index that had only some of its primary shards allocated before it was closed. Fixes elastic#8224
imotov
force-pushed
the
issue-8224-restore-with-missing-local-shards
branch
from
158f727
to
b0dde6e
Compare
|
@imotov should this go into |
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue with restoring of an index that had only some of its primary shards allocated before it was closed.
Fixes #8224