Inverse DocIdSets' heuristic to find out fast DocIdSets. #8380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * Do not call this method directly, use {@link DocIdSets#isFastIterator}. | ||
| */ | ||
| public abstract boolean hasFastIteration(); |
There was a problem hiding this comment.
Can not name this hasFastIterator?
I feel the name continues to encourage that such slow filters are ok. If we are planning to add support for broken iterators to DocIdSetIterator as a method (I'm honestly not sure how i feel about this), then i think the method should be something like isBroken() and should be deprecated to discourage adding more broken iterators.
|
@rmuir I renamed the method to |
|
+1 ! |
DocIdSets.isFast(DocIdSet) has two issues: - it works on the DocIdSet interface while some doc sets can generate either slow or fast sets depending on their options (eg. whether an OrDocIdSet is fast or not depends on the wrapped clauses). - it only works because the result of this method is only taken into account when a DocIdSet has non-null `bits()`. This commit changes this method to work on top of a DocIdSetIterator and to use a black-list rather than a white list: slow iterators should really be the exception rather than the rule. Close elastic#8380
jpountz
force-pushed
the
fix/fast_doc_sets
branch
from
2831b51
to
1448136
Compare
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DocIdSets.isFast(DocIdSet) has two issues:
slow or fast iterators depending on their options (eg. whether an OrDocIdSet is
fast or not depends on the wrapped clauses).
when a DocIdSet has non-null
bits().Here is a proposal to change this method to work on top of a DocIdSetIterator
and to use a black-list rather than a white list: slow iterators should
really be the exception rather than the rule.