Raise an exception on an array of values being sent as the factor for a field_value_factor query
#9246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dakrone could you review please? |
| @@ -70,6 +70,8 @@ public ScoreFunction parse(QueryParseContext parseContext, XContentParser parser | |||
| } else { | |||
| throw new QueryParsingException(parseContext.index(), NAMES[0] + " query does not support [" + currentFieldName + "]"); | |||
| } | |||
| } else if("factor".equals(currentFieldName) && token == XContentParser.Token.START_ARRAY) { | |||
There was a problem hiding this comment.
Can you add a check for XContentParser.Token.START_OBJECT as well here, since it can't be an object either?
|
@reuben-sutton left one comment here, if you can address that I will merge this! |
|
Hi @dakrone - just pushed the change requested. Sorry it took so long! |
|
@reuben-sutton looks great, if you squash it into a single commit I will push it! |
… a field_value_factor query closes elastic#7408
reuben-sutton
force-pushed
the
field_value_factor_error_on_array
branch
from
857d74d
to
d0c5d8c
Compare
|
Thanks @dakrone. Squashed! On Tue, Feb 3, 2015 at 8:43 PM, Lee Hinman notifications@github.com wrote:
|
|
Merged this to master and 1.x, thanks @reuben-sutton ! |
clintongormley
changed the title
field_value_factor query
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7408