Remove redundant fs metadata ops. #9807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files.exists(f) && Files.isDirectory(f) -> Files.exists(f) if (Files.exists(f)) Files.delete(f) -> Files.deleteIfExists(f) if (!Files.exists(f)) Files.createDirectories(f) -> Files.createDirectories(f) In a few places where successive i/o ops are done against the same file, convert to Files.readAttributes().
|
LGTM |
|
@rmuir should be also backport to 1.x where applicable? |
|
These are NIO.2 cleanups, when i look at 1.x its still using java.io.File. This makes things tricky... |
|
I see.... |
|
Lemme look more. we can do a little bit, but it won't be as good. For example File.isDirectory implies File.exists just like it does for NIO.2 |
|
yea, make sense. My answer was short since maybe to improve the file system API usage in 1.x, we might need to backport the NIO.2 work, so am on the fence as to what is the best path... |
|
I think that is somewhat tricky since on 1.x we have lucene 4, which itself is not using NIO.2. But we can at least remove any redundant exists() for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some easy cleanups:
Files.exists(f) && Files.isDirectory(f) -> Files.isDirectory(f)
if (Files.exists(f)) Files.delete(f) -> Files.deleteIfExists(f)
if (!Files.exists(f)) Files.createDirectories(f) -> Files.createDirectories(f)
In a few places where successive i/o ops are done against the same file, convert
to Files.readAttributes().