Move GapPolicy and resolveBucketValues() to static helper methods #9954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@polyfractal can you add some javadocs to the methods and class? |
|
Oops, sure. Didn't think about it since the aggs 2.0 stuff is in such high flux. Will add some in a minute (and the new class needs apache headers too) |
| import java.util.List; | ||
|
|
||
|
|
||
| public class ContiguousBucketHelpers { |
There was a problem hiding this comment.
Could probably just call this BucketHelpers instead of ContiguousBucketHelpers?
|
@polyfractal left one super minor comment and I agree with @dakrone that we should have JavaDocs (sorry that was my fault for not putting them there to begin with) but otherwise looks great |
Will allow many reducers to share the same helper functionality without repeating code. Chose to put these in static helpers instead of adding to Reducer base class. I can imagine other reducers that aren't time-based (or don't care about contiguous buckets), which would make things like gap policy useless. Since these seemed more like helpers than inherent traits of a Reducer, they went into their own static class.
polyfractal
force-pushed
the
feature/aggs_2_0_gapdryrefactor
branch
from
9bab4c7
to
ddbeaff
Compare
|
LGTM |
polyfractal
added a commit
that referenced
this pull request
Mar 5, 2015
Will allow many reducers to share the same helper functionality without repeating code. Chose to put these in static helpers instead of adding to Reducer base class. I can imagine other reducers that aren't time-based (or don't care about contiguous buckets), which would make things like gap policy useless. Since these seemed more like helpers than inherent traits of a Reducer, they went into their own static class. Closes #9954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will allow reducers to share the same helper functionality without repeating code.
Since these seemed more like helpers than inherent traits of a Reducer (e.g. we could have non-time based reducers, or reducers that don't care about contiguous buckets), I put them into their own static class.
I imagine we'll need a
NonContiguousBucketHelperssomeday that offers similarresolveBucketValue(), but without the gap policy stuff?