Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit relative path or $PATH searches for the java command. #1280

Merged
merged 1 commit into from Apr 16, 2014
Merged

Permit relative path or $PATH searches for the java command. #1280

merged 1 commit into from Apr 16, 2014

Conversation

jordansissel
Copy link
Contributor

This fixes the following broken in #1189:

% bin/logstash
=> Could not find any executable java binary. Please install java in your PATH or set JAVA_HOME.

@jordansissel
Permit relative path or $PATH searches for the java command.
c471297 
This fixes the following broken in elastic#1189:

    % bin/logstash
    => Could not find any executable java binary. Please install java in your PATH or set JAVA_HOME.
@jordansissel
Copy link
Contributor Author 

% git checkout master
Switched to branch 'master'
Your branch is up-to-date with 'upstream/master'.
% git rev-parse HEAD
bfc76195dc1435e9d793e99062272fe9becb4774
% bin/logstash version
Could not find any executable java binary. Please install java in your PATH or set JAVA_HOME.

% git checkout fix-bin-logstash
Switched to branch 'fix-bin-logstash'
% git rev-parse HEAD
c4712971ca3b2cce8a5b43b8ad06e904fb0dcf4c
% bin/logstash version
logstash 1.4.1.dev

@colinsurprenant
Copy link
Contributor

LGTM

colinsurprenant added a commit that referenced this pull request Apr 16, 2014
@colinsurprenant
Merge pull request #1280 from jordansissel/fix-bin-logstash
95fedf6 
Permit relative path or $PATH searches for the java command.
@colinsurprenant colinsurprenant merged commit 95fedf6 into elastic:master Apr 16, 2014
@jordansissel jordansissel deleted the fix-bin-logstash branch April 16, 2014 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jordansissel @colinsurprenant