Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MITM of https requests doesn't allow %2F in the URL #61

Open
mjg123 opened this issue Oct 2, 2014 · 2 comments
Open

MITM of https requests doesn't allow %2F in the URL #61

mjg123 opened this issue Oct 2, 2014 · 2 comments

Comments

@mjg123
Copy link

mjg123 commented Oct 2, 2014

I use:
proxy.OnRequest().HandleConnect(goproxy.AlwaysMitm)

then, try to browse https://review.openstack.org but some pages break because of %2F in URLs like:
https://review.openstack.org/projects/openstack%2Fnova/config

I assume these are being proxied into requests for https://review.openstack.org/projects/openstack/nova/config - which is a 404

@elazarl
Copy link
Owner

elazarl commented Oct 5, 2014

Hi,
Since %2F is equivalent to / in URL encoding, it looks like Go's net/http.Request parser loses this information.

I'll investigate further later today.

Apologize for the time it took me to get back to you. Holidays season.

@mjg123
Copy link
Author

mjg123 commented Oct 5, 2014

Yes - you've inherited a bug in a standard library by the looks of things: http://play.golang.org/p/vaIhOr1VUl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants