Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published to npm as ES6, can you do ES5? #1

Closed
avindra opened this issue May 14, 2016 · 6 comments
Closed

Published to npm as ES6, can you do ES5? #1

avindra opened this issue May 14, 2016 · 6 comments

Comments

@avindra
Copy link

avindra commented May 14, 2016

Hi,

Any chance you can publish this to npm as ES5?

I pulled this into my project and our entire build process broke (Webpack) because we exclude babel transformations for files under node_modules in our project.

@avindra
Copy link
Author

avindra commented May 14, 2016

For others with the same issue, you can workaround it by telling Webpack to babelify these modules:

-                exclude : /(?:node_modules)/,
+                exclude : /(?:node_modules)\/(?!(fuzzy-string-matching|longest-common-subsequence))/,

@elazzabi
Copy link
Owner

elazzabi commented May 14, 2016

I'm working on it to fix the issue
Sorry for inconvenience

@elazzabi
Copy link
Owner

Done. Can you test after updating the module?

@avindra
Copy link
Author

avindra commented May 15, 2016

Thanks for the quick turnaround @elazzabi. I'll test the new version when I go into the office on Monday 👍

@avindra
Copy link
Author

avindra commented May 16, 2016

Works fine now. Thanks man

@elazzabi
Copy link
Owner

You are welcome 😸

Repository owner locked and limited conversation to collaborators May 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants