Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log about ungroup() #32

Closed
damianooldoni opened this issue Oct 30, 2019 · 3 comments
Closed

Add log about ungroup() #32

damianooldoni opened this issue Oct 30, 2019 · 3 comments

Comments

@damianooldoni
Copy link
Contributor

damianooldoni commented Oct 30, 2019

While doing this:

df %>% 
  group_by() %>% 
  summarize() %>% 
  ungroup()

I get this as last message: summarize: now xx rows and yy columns, zz group variables remaining, where xx, yy and zz are numbers.
It would be nice, I think, to have a message for ungroup() as well.
Something like: ungroup: no grouping variables left or just ungrouped.
What do you think? Thanks.

@elbersb
Copy link
Owner

elbersb commented Oct 30, 2019

Yes, this is probably a good idea. In the beginning I was reluctant to add logs for these trivial commands, but it makes the package more consistent. Not sure when I get around to this. As always, open to PRs as well.

@damianooldoni
Copy link
Contributor Author

I will give a try.

@elbersb
Copy link
Owner

elbersb commented Nov 10, 2019

closed in #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants