Skip to content

Commit

Permalink
Remove import from urls.py that hooks up receivers
Browse files Browse the repository at this point in the history
This is a backwards incompatible change, of which the details
can be found in the docs/changelog.rst

Fixes #5
  • Loading branch information
paltman committed Jan 31, 2013
1 parent bb87ac8 commit 53e73e0
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 3 deletions.
14 changes: 14 additions & 0 deletions docs/changelog.rst
Expand Up @@ -7,11 +7,25 @@ CHANGELOG
1.2
===

* BACKWARD INCOMPATIBILITY: removed the import of `kaleo.receivers` from `urls.py`
* added a `joined_independently` signal
* refactored logic that existed in signal receivers to model methods
* fixed bug in add invites functionality that would set everyone to have unlimited invites
* fixed bug in top off invites functionality that removed unlimited invites from those who had it

Backward Inccompatibilities
---------------------------

Importing things into `models.py` or `urls.py` that have nothing to do with either of those
modules has been a bit of a hack for awhile. Pinax is moving to a more explicit approach where
these things are hooked up at the project level. In fact, Pinax starter projects will support
`receivers.py` getting hooked up at runtime automatically through the use of a `startup.py`
modeule that has code that gets executed in the `wsgi.py` and `manage.py`.

See how it all works in this commit:

https://github.com/pinax/pinax-project-account/commit/364795cdd683574ab6a5093be34b9d47a3487bea


1.1
===
Expand Down
3 changes: 0 additions & 3 deletions kaleo/urls.py
@@ -1,13 +1,10 @@
from django.conf.urls.defaults import url, patterns

import kaleo.receivers

from kaleo.views import invite, topoff_all, addto_all, topoff_user, addto_user, invite_stat


urlpatterns = patterns("",
url(r"^invite/$", invite, name="kaleo_invite"),

url(r"^invite-stat/(?P<pk>\d+)/$", invite_stat, name="kaleo_invite_stat"),
url(r"^topoff/$", topoff_all, name="kaleo_topoff_all"),
url(r"^topoff/(?P<pk>\d+)/$", topoff_user, name="kaleo_topoff_user"),
Expand Down

0 comments on commit 53e73e0

Please sign in to comment.