All my previous pull requests, plus some bits #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Turned the JavaScript code in to a jQuery plugin, removed most of the
initialization code from the individual widget templates to a external
JavaScript file, and added a {% phileo_js %} tag to load this plugin.
- Each like button gets a unique ID, so multiple like buttons can appear
on a single page
- Made the widget a plain old form. This way, it works without
JavaScript. Additionally, the CSRF stuff is included in the form by
default, so the ajax_csrf.js script is obsolete
Why was it even there?
|
Tim, First let me say, THANKS! I appreciate all the pull requests and explanations. I will be reviewing them and merging them for a target of a new release ASAP. Patrick |
The widget_id when rendering a like widget defaulted to None, which broke the widget when no id was supplied. This creates a default id for widgets, which should be unique for that model instance.
{% likes user as like_list %} defaults to using all registered models
when no models are specified, to allow easy listing of all likes in an
application - which is probably the main use case for this.
{% render_like like %} renders the given like and prints it in the
template. The template that it uses depends upon the liked instance, and
is either:
* phileo/<app>/<model>.html
* phileo/<app>/like.html
* phileo/like.html
This allows for custom like templates on a per model and per application
basis.
|
I really disagree with the "Remove all the CSS cruft..." commit. It's not wrong to ship with some css that just works out of the box. It's not dictating anything as you can just not include the css by omitting the tag and style it yourself as a site developer. |
|
Can you update your fork with the master from this repo and create two new pull requests with the last two commits you have there (like list tag -- will need to be reworked based on the settings change I made where I use setting instead of registry, and the render_like tag)? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the individual pull requests I sent (#2, #3, #4) are stand alone chunks of work, but here is a branch containing all of them, plus some extra clean up that does not deserve a pull request of its own. This is how I am using this app in the application that I am currently building, and is how I envisioned my changes to ultimately be applied.