Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code responsibility actions #30

Closed
eldoy opened this issue Jan 24, 2022 · 2 comments
Closed

Code responsibility actions #30

eldoy opened this issue Jan 24, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@eldoy
Copy link
Owner

eldoy commented Jan 24, 2022 •
edited

  1. Move keep and remove to extras? Make it work with dot notation.
  2. Remove $.keep and remove, it is in tools (extras), also from docs
  3. Move allow and deny to d8a. Need to be normal validation errors
  4. d8a needs strict mode with required false. see d8a issue.
  5. Can have required: [field1, field2, field3] as array in validation? Goes in d8a.
@eldoy eldoy added the enhancement New feature or request label Jan 24, 2022
@eldoy
Copy link
Owner Author

eldoy commented Jan 24, 2022 •
edited 

error: { message: 'validation error' }
values: { account_id: ['field is not allowed']}

@eldoy
Copy link
Owner Author

eldoy commented Jan 25, 2022

Done.

@eldoy eldoy closed this as completed Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eldoy