Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a .env variable to change the save location of the final video #333

Merged
merged 5 commits into from Jun 7, 2022
Merged

Added a .env variable to change the save location of the final video #333

merged 5 commits into from Jun 7, 2022

Conversation

DomizianoScarcelli
Copy link
Contributor

@DomizianoScarcelli DomizianoScarcelli commented Jun 6, 2022

I added a .env variable called FINAL_VIDEO_PATH, where the user can insert the path of the directory where the video will be saved.
If the user inserts a bad path or doesn't at all, the video will be saved in the default directory (assets/).

Fixes #315

@callumio callumio changed the base branch from master to develop June 6, 2022 19:55
Copy link
Collaborator

@callumio callumio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - if you could fix the conflicts and address the import, I'm happy to merge these changes

video_creation/final_video.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@callumio callumio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@callumio callumio merged commit 757477c into elebumm:develop Jun 7, 2022
@DomizianoScarcelli DomizianoScarcelli deleted the change-video-location branch June 7, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change save location
2 participants