A couple of features and bug fixes #232

r0x0r · 2014-09-15T20:22:40Z

Hello there,
I have been testing out Lychee fixing bugs and adding minor features in progress. Here is a list of the changes I have introduced so far.

Faster photo browsing thanks to caching.
Default sort order of albums is changed from new to old.
Preserves scroll position when changing from albums to album and vice versa
Better Unicode support for values read from the database

Hopefully these are of use to you. If you have any questions, do not hesitate to ask.

Cheers,
Roman

- The albums view is stored in memory when changing from the albums to the individual album/photo view. - When viewing photos, the next picture in the current album is preloaded. * Default sort order of albums is changed from new to old. * Fixed scroll position when changing from albums to album and vice versa

Conflicts: assets/min/main.js

…ane because of the old cache copy

electerious · 2014-09-16T10:49:09Z

That sounds great! Give me some time to look through all those changes.

A few things that need to be fixed/done before:

Use tabs for indentation, not spaces
Update the code to the current master state

Thanks for your work!

r0x0r · 2014-09-16T12:27:54Z

Hello,

Sorry about the spaces. Changed them to tabs now.
What do you mean by updating to the current master state, though? I am still learning my ways around Git.

Cheers,
Roman

On 16 Sep 2014, at 13:49, Tobias Reich notifications@github.com wrote:

That sounds great! Give me some time to look through all those changes.

A few things that need to be fixed/done before:

Use tabs for indentation, not spaces
Update the code to the current master state
Thanks for your work!

—
Reply to this email directly or view it on GitHub.

electerious · 2014-09-16T12:44:45Z

Some parts of Lychee have changed since you forked the project. You need to make sure that your branch is up to date with the master of Lychee before I can merge everything.

electerious · 2014-09-16T18:33:57Z

assets/js/build.js

-		modal +=			"<input id='username' type='text' name='' value='' placeholder='username'>";
-		modal +=			"<input id='password' type='password' name='' value='' placeholder='password'>";
+		modal +=			"<input id='username' type='text' name='username' value='' placeholder='username'>";
+		modal +=			"<input id='password' type='password' name='password' value='' placeholder='password'>";


Are these changes good for something (Nothing again them, just curious)?

I have been trying to make Chrome to save a password and this was one of solutions, but alas it did not work out. I will investigate this issue.

I have merged with the latest master. Do you want me to create a new pull request?

Cheers,
Roman

On 16 Sep 2014, at 21:34, Tobias Reich notifications@github.com wrote:

In assets/js/build.js:

@@ -195,8 +195,8 @@ build = {
modal += "
Sign In
";
modal += "";
modal += "
";

modal += "<input id='username' type='text' name='' value='' placeholder='username'>";

modal += "<input id='password' type='password' name='' value='' placeholder='password'>";

modal += "<input id='username' type='text' name='username' value='' placeholder='username'>";

modal += "<input id='password' type='password' name='password' value='' placeholder='password'>";
Are these changes good for something (Nothing again them, just curious)?

—
Reply to this email directly or view it on GitHub.

A new PR including the other changes would be nice.

electerious · 2014-09-16T18:54:33Z

Went through the code. Looks great! Thanks for the work. Some small things here and there and we can merge it :)

… album in the album view

r0x0r · 2014-09-17T15:21:33Z

I have updated the code with the changes proposed by you, plus added another fix for an albums cache issue when renaming an album.

electerious · 2014-09-17T21:13:51Z

Awesome job! I opened a new v2.6.3 branch with all your changes. Thanks a lot :) Feel free to create new PRs from this branch.

electerious · 2014-09-19T17:19:55Z

assets/js/lychee.js

@@ -190,11 +190,12 @@ var lychee = {
 				album.load(albumID, true);
 			}
 			photo.load(photoID, albumID);
+            photo.preloadNext(photoID,albumID);


Would be better to preload the next photo after the current photo has been loaded (it should have the higher priority). What do you think?

I agree with you that it is a good idea. The change is now pushed.

On Fri, Sep 19, 2014 at 8:19 PM, Tobias Reich notifications@github.com
wrote:

In assets/js/lychee.js:

@@ -190,11 +190,12 @@ var lychee = {
album.load(albumID, true);
}
photo.load(photoID, albumID);

photo.preloadNext(photoID,albumID);

Would be better to preload the next photo after the current photo has been
loaded (it should have the higher priority). What do you think?

—
Reply to this email directly or view it on GitHub
https://github.com/electerious/Lychee/pull/232/files#r17796876.

electerious · 2014-09-19T21:47:21Z

Found out the the scroll position isn't always correct (Tested with Safari & Chrome). When you are too near to the top, it just goes back to the top and sometimes it has an offset with about -200px to the last position. Any idea?

r0x0r · 2014-09-20T21:28:31Z

I have noticed this erratic behaviour, but to be honest I have no idea what
causes it. Will see if I can find a solution.

Roman

On Sat, Sep 20, 2014 at 12:47 AM, Tobias Reich notifications@github.com
wrote:

Found out the the scroll position isn't always correct (Tested with Safari
& Chrome). When you are too near to the top, it just goes back to the top
and sometimes it has an offset with about -200px to the last position. Any
idea?

—
Reply to this email directly or view it on GitHub
#232 (comment).

r0x0r added 9 commits September 14, 2014 14:31

* Improved performance by caching:

f17ee01

Fixed broken scrolling when changing albums<->album views

b8020fb

New readme file

8b8295d

added min files

c4df00d

Merge branch 'rambutan'

c655fd0

Conflicts: assets/min/main.js

Added proper unicode support for values read from mysql

f886793

Updated README

5948bf4

Fixed a bug where a newly created album does not show in the albums p…

1671517

…ane because of the old cache copy

Changed spaces to tabs for indentation

fa8cad0

electerious reviewed Sep 16, 2014
View reviewed changes

r0x0r added 4 commits September 16, 2014 23:51

Merged with the latest pull from the origin

7026ea8

Minor tweaks and corrections based on Tobias's comments

4ce4048

Fixed an album name not updating in the albums view when renaming the…

4b8c4a4

… album in the album view

A null check fix to the previous commit

a0d11ca

electerious added a commit that referenced this pull request Sep 17, 2014

Small code adjustments #232

582a8a3

electerious closed this Sep 17, 2014

electerious reviewed Sep 19, 2014
View reviewed changes

electerious mentioned this pull request Oct 9, 2014

v2.6.3 #238

Merged

electerious added a commit that referenced this pull request Oct 9, 2014

Temporary removed preload #232

436dcfe

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

A couple of features and bug fixes #232

A couple of features and bug fixes #232

r0x0r commented Sep 15, 2014

electerious commented Sep 16, 2014

r0x0r commented Sep 16, 2014

electerious commented Sep 16, 2014

electerious Sep 16, 2014

r0x0r Sep 16, 2014

electerious Sep 17, 2014

electerious commented Sep 16, 2014

r0x0r commented Sep 17, 2014

electerious commented Sep 17, 2014

electerious Sep 19, 2014

r0x0r Sep 20, 2014

electerious commented Sep 19, 2014

r0x0r commented Sep 20, 2014

A couple of features and bug fixes #232

A couple of features and bug fixes #232

Conversation

r0x0r commented Sep 15, 2014

electerious commented Sep 16, 2014

r0x0r commented Sep 16, 2014

electerious commented Sep 16, 2014

electerious Sep 16, 2014

Choose a reason for hiding this comment

r0x0r Sep 16, 2014

Choose a reason for hiding this comment

Sign In

electerious Sep 17, 2014

Choose a reason for hiding this comment

electerious commented Sep 16, 2014

r0x0r commented Sep 17, 2014

electerious commented Sep 17, 2014

electerious Sep 19, 2014

Choose a reason for hiding this comment

r0x0r Sep 20, 2014

Choose a reason for hiding this comment

electerious commented Sep 19, 2014

r0x0r commented Sep 20, 2014