Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several bugs #2

Closed
shawnyve opened this issue Jan 22, 2022 · 7 comments
Closed

Several bugs #2

shawnyve opened this issue Jan 22, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@shawnyve
Copy link

shawnyve commented Jan 22, 2022

I understand this is brand new and in testing so hopefully, this helps out.
I'm having several issues, perhaps all related.

1st. Nothing appears to happen on some items that have Vendor Buy prices when clicking on Vendor Location menu most of the time. See 2nd issue.

2nd. When clicking on Sort/Unsort which generally appears for me just above Vendor Location, on an item that can be bought, it does work. Okay, further testing showed some items work in the Armory clicking Vendor Location others I have to click sort/unsort to get the vendor list. What items do work using Vendor Location? Skysteel Hatchet, Softstepper's Turban, Custom Made Robe of Casting, and a few others which can be bought at the Calamity Vendor. What doesn't work? lots of other equipment that can be bought OR crafted. This could be the same in inventory/retainers as well.

3rd. Doesn't seem to work for Gemstone Vendor stuff. I'm guessing this is a different system but should prob state in the description it doesn't.

Feel free to msg me on discord for more info. I'm in the Goat discord. can dm me from there.

@electr0sheep
Copy link
Owner

Thanks for taking a look. Out of curiosity, do you use the MarketBoardPlugin?

@rrbailey89
Copy link

I also experience issue 2. Most items that I search for vendor location in my inventory nothing happens until I press the sort button.

@electr0sheep
Copy link
Owner

In my own testing, I have seen this as well. There is an issue with a certain library that causes it. If you try disabling other plugins that modify the inventory context menu, then reload this plugin, the issue should resolve. Specifically for me, the MarketBoard plugin was causing the issue (not through fault of the developer). I was also able to reproduce this same bug using the PriceCheck plugin.

@thisischrys
Copy link

Any news on this?
Marketboard and this plugin really shine when used together (Find it cheapest at an NPC, else cheapest on marketboard).
Right now I'm disabling one or the other when I need stuff and it's starting to get tiresome.

@electr0sheep
Copy link
Owner

I think there is a fix in the works that will allow plugins to modify context menus without resulting in things like this. As soon as that gets released (and somebody else figures out how to use it), I will update the plugin.

@thakyZ
Copy link

thakyZ commented Feb 24, 2022

Yea, the second one is because of what @thisischrys mentioned. I have tested it too, and I can confirm that it is because of the market board plugin. I was actually coming here to report it.

@electr0sheep
Copy link
Owner

I'm going to close this out, since I think the only thing outstanding is the context menu issue, which I've made a separate issue for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants