Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Issue] "color blind mode" checkbox text misalignment #2009

Closed
Chopinsky opened this issue Oct 3, 2019 · 3 comments
Closed

[UI Issue] "color blind mode" checkbox text misalignment #2009

Chopinsky opened this issue Oct 3, 2019 · 3 comments

Comments

@Chopinsky
Copy link
Contributor

It seems that the "color blind mode" checkbox's text is slightly misaligned with the box. This should be fixable with some CSS.

  • Chrome
    image

  • Firefox
    image

  • Edge
    image

In addition, it seems that the checkbox is quit buried in the lower right corner of the sidebar, making it less accessibility-friendly.

Ideally, we probably should make it into a toggle button along with right side toggle buttons (e.g. right below the dark-mode button), but at least we can make the checkbox larger and right beneath the country selection list.

@ystanwar
Copy link

ystanwar commented Oct 4, 2019

Hi can I take this issue

ovbm pushed a commit that referenced this issue Oct 9, 2019
…2010)

* Update checkbox styles and make it obvious

* Also move the mobile version of the checkbox up in the contents

* Update checkbox styles and add border-radius

* Updating checkbox container name
@fbarl
Copy link
Contributor

fbarl commented Jan 16, 2020

It seems that #2010 addressed this issue for the desktop mode:

image

So the only piece of work left is to update the mobile view with the same styles:

image

@corradio
Copy link
Member

OK. Closing this issue. feel free to re-open if the issue reappears

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants