Adds support for using feature-query-parameters #3580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skovhus
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #3575
This will make it possible to try out new features before they are publicly released.
For now, this will be possible by setting a query-parameter which can both be used in frontend and will also be sent to the app-backend.
Usage
Add a
?feature=XXXparameter to the URL. I have also added support for a comma-separated list, so one can test multiple features simultaneously :)Preview
NOTE
While at it, I also fixed a bug, where the app would get caught in a loop constantly calling the backend - it only happens if the backend returns empty data, which shouldn't happen unless something is down (but it happens more frequently when developing locally).