Fix GB wind being None #3609
Merged
Fix GB wind being None #3609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corradio
reviewed
Dec 20, 2021
| @@ -238,7 +238,7 @@ def _fetch_wind(target_datetime=None): | |||
|
|
|||
| # line up with B1620 (main production report) search range | |||
| d = target_datetime.date() | |||
| start = d - dt.timedelta(hours=24) | |||
pierresegonne
added a commit
that referenced
this pull request
Feb 23, 2022
* Isort * Request wind data further back * Add wind to required field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Quite regularly, the wind production for edge hours (23:00 UTC which is 00:00 Europe/London) would be converted to None. This happens because there is a temporal gap between the data original fetched, and the wind fetched ad-hoc, meaning that we loose data for that half hour.
Reproduce:
poetry run python test_parser.py GB production --target_datetime 2019-09-20Description
Makes sure to fetch enough data to match wind production against the other production modes, and add fail safe fallback by making wind required.