Adds loading indicator while fetching history #3874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kongkille
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
This is great.
I am wondering if we'd want to still show the name of the zone while loading? I think it's nice small feedback that the users know they have clicked the right zone and is now awaiting the detailed data.
(I realize it's less than a second usually)
Adds a bit of extra work, so regardless we could address that in another PR
|
Good point @Kongkille, I have changed it to this now:
I also fixed the back-arrow button being white on hover so you couldn't see it 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes it clear to users that data is being fetched, instead of first showing "no data is available" until data for a zone is loaded.
Before
After