Remove momentjs #4070
Merged
Remove momentjs #4070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
This was referenced May 3, 2022
madsnedergaard
approved these changes
May 8, 2022
Yeah I saw someone mentioning it in a old issue (can't find it now) and figured it would be a really nice benefit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes momentjs and replaces it with date-fns helper functions and native code.
This alone shaves almost 250kb of the vendor bundle (before gzip).
Most of the changes are pretty simple but I decided to use
Intl.DateTimeFormatandIntl.RelativeTimeFormatto localize string, this is somewhat a breaking change as it no longer automatically pick a unit (hour, days, months, etc) and only use the specified unit (hour in this case). It should not be a problem but might look a bit weird to see 2000+ hours when doing local development. 馃槄### NO IE 11 SUPPORT!AsWith the merger of #4082 this is no longer relevant. 馃檪Intl.RelativeTimeFormatis not supported by IE 11 this means we would no longer support IE 11, I personally think this is the right way forward as Microsoft themselves will stop supporting it next month as mentioned in #4034.