Improve contributorlist.jsx and zones.json #4081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsnedergaard
approved these changes
May 5, 2022
q--
reviewed
May 10, 2022
| srcSet={`https://avatars.githubusercontent.com/${contributor}?s=40 2x`} // loads the avatar image at a default size of 40px for high resolution displays | ||
| alt={contributor} | ||
| height="20px" | ||
| width="20px" |
There was a problem hiding this comment.
Are you sure using px in these attributes is allowed?
There was a problem hiding this comment.
Oh crap you are right, according to MDN they are supposed to be without units...
It works just fine with for me with units in Firefox and Chrome though but might be best to change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
https://github.com/prefix from the contributors inzone.json.contributorlist.jsxcomponent to handle the newzone.jsonchanges.contributorlist.jsxlike lazy loading and adding srcset.This will reduce the main bundle size and give users a better overall experience.