Add overrides for isLowCarbon and isRenewable contributions for CH #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corradio
approved these changes
May 5, 2022
|
@FelixDQ let's have a look together before merging, I'd like to discuss data format for these parameters (TLDR they don't respect the same format as the other parameters) |
FelixDQ
reviewed
May 6, 2022
There was a problem hiding this comment.
I would probably also update the other values, so that we only use numbers and not a combination of booleans and numbers.
Also remember that we need to update the code here when we merge this:
https://github.com/electricitymap/electricitymap/blob/master/libs/flowtracing/electricitymap/flowtracing/flowtracing.py#L326-L334
FelixDQ
approved these changes
May 6, 2022
pierresegonne
commented
May 6, 2022
| @@ -138,6 +160,80 @@ def callback2(ratio, _zone): | |||
| ) | |||
| self.check_power_origin_ratios(callback1, callback2) | |||
|
|
|||
| def check_contribution_object(self, contribution, zone, mode, contribution_name): | |||
There was a problem hiding this comment.
testing for two things mainly:
- datetimes - if the contributions for a mode are given as a list with datetimes, we verify that each element of the list have a valid datetime + that the list is ordered by these datetimes
- values for the contributions - check that all contributions have a key "value" and that the value is between 0 and 1
pierresegonne
deleted the
ps/add_overrides_for_unknown_renewable_lowCarbon_CH
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds zoneOverrides for the considering the contribution of
unknownto the renewable and carbon-free percentages for CH.The rationale is detailed in the source provided, but the TLDR; is that 52% of the unknown is hydro discharge, for a zone where more than 80% of the production is carbon free.