Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 5 migration prep (update css loaders and webpack config) #4089

Merged
merged 5 commits into from
May 8, 2022

Conversation

VIKTORVAV99
Copy link
Member

This PR is the start of a long process to get us ready to upgrade to webpack 5.

It:

  • updates all the css loaders to the highest version that still support webpack 4.
  • switches the use of autoprefixer to postcss-env (it includes autoprefixer among other plugins)
  • removes the custom function to output mainfest.json as it's not supported by webpack 5
  • adds the BundleAnalyzerPlugin to output the manifest.json file again
  • clean up the webpack-config.js file by removing options that won't be supported in webpack 5 or changing them to supported versions.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file frontend 🎨 labels May 5, 2022
@VIKTORVAV99 VIKTORVAV99 mentioned this pull request May 5, 2022
5 tasks
@VIKTORVAV99
Copy link
Member Author

Turns out there won't be a long process!

I have a stable version that use Webpack 5 locally and can push it here or add a separate PR after this is one merged.

Let me know what you think is best!

@madsnedergaard
Copy link
Member

madsnedergaard commented May 6, 2022

Lets do a separate PR to make testing easier :)
I'll review this today!

Copy link
Member

@madsnedergaard madsnedergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and AFAIK it works just fine - so let's try it! 🙃

@VIKTORVAV99
Copy link
Member Author

Hehe dev dependencies are the "safe" ones.

It's when we need to update the production dependencies I start to worry. 😅

@madsnedergaard madsnedergaard enabled auto-merge (squash) May 8, 2022 17:24
@madsnedergaard madsnedergaard merged commit aa22456 into electricitymaps:master May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file frontend 🎨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants