Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix app wrongfully saying app is updated. #4108

Merged
merged 4 commits into from
May 10, 2022
Merged

Fix app wrongfully saying app is updated. #4108

merged 4 commits into from
May 10, 2022

Conversation

Kongkille
Copy link
Contributor

Fixes #3995

  • Adds button to force hide outdated version
  • Remove cache on client-version.json

madsnedergaard
madsnedergaard approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@madsnedergaard madsnedergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitty nitty picky picky 🐱
But approving nonetheless and thanks for fixing it!

Markus Killendahl and others added 2 commits May 10, 2022 11:38
@madsnedergaard
Update web/src/layout/main.jsx
31681dc 
Co-authored-by: Mads Nedergaard <nedergaardmads@gmail.com>
Merge branch 'master' into mk/fix-outdated-version
a27c9fa
@Kongkille Kongkille enabled auto-merge (squash) May 10, 2022 09:38
@Kongkille
Copy link
Contributor Author

cc @corradio as I know you've spotted this a few times, lmk if it gives you any trouble now!

@Kongkille Kongkille merged commit bb96144 into master May 10, 2022
@Kongkille Kongkille deleted the mk/fix-outdated-version branch May 10, 2022 09:43
@FelixDQ FelixDQ mentioned this pull request Jun 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsnedergaard madsnedergaard madsnedergaard approved these changes

Assignees
No one assigned
Labels
frontend 🎨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App wrongfully says a new version is available
2 participants
@Kongkille @madsnedergaard