-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged ES_CN and ES_IB parsers #4303
Merged ES_CN and ES_IB parsers #4303
Conversation
@madsnedergaard I am holding off on this for a bit until a new version of EDIT: |
Hmm I have no idea why the CI check is suddenly failing, it's working for me locally and the changes shouldn't have affected anything. EDIT: |
@hectorespert Hey could you publish a new version of EDIT: |
@madsnedergaard This should be ready for review now, the failing CI check appears to be because the test runner is trying to run the archived tests which obviously don't work as the relative imports are broken. I think this is outside of the scope of this PR and should be fixed in a separate PR but a quick solution would be to delete the archived tests. (On a side note it looks like every test is run twice? Might want to look into that too if you decide to poke around in the test config.) |
I think deleting the test makes most sense - if we really wanted to we could add a comment in the archived parser with a reference to the commit where it's available... but since we're just merging the two parsers here (and probably don't want to revert to two different ones) I think you could also just delete the parsers entirely :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! 👏
On an unrelated personal note I'm going on 3 months parental leave from today, so if you need to reach someone on the team, @Kongkille is the man 💪
Have fun with the kid(s)! 🎉 I'll just do a final check for unused code/variables and then I'll merge this. |
This PR merges the ES_CN.py and ES_IB.py parsers into a combined ES.py parser.
In this PR:
The reason I wanted to do this is so we don't need to maintain two extremely similar parsers and to open up for adding the Spanish autonomous cities of Ceuta and Melilla in the future.