Migrate Python tests to GitHub actions #4315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dependencies
github-actions
bot
added
the
dependencies
github-actions
bot
added
the
dependencies
VIKTORVAV99
commented
Jul 2, 2022
|
Any thoughts here @FelixDQ? |
FelixDQ
reviewed
Jul 6, 2022
It could but the new CI jobs aren't marked as required yet so I have held off on doing that for now. I think it's best to merge these, let them run for a little while to make sure it's consistent then mark them as required and remove the circleCI jobs once we have the same functionality. (the last job to migrate is the web build job) |
github-actions
bot
added
the
dependencies
|
@FelixDQ made the changes you requested, there should be nothing blocking this now. 🙂 |
FelixDQ
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this PR is a direct port of the CircleCI job but I have added review comments for the changes that are not straight forward so please have a look at those.