Update assets/text #4330
Update assets/text #4330
Conversation
|
Will the "company name" also change for the app stores? PS: Might want to rename the entire file too to stay consistent. |
| <path d="M256 438.95C266.176 438.95 274.425 430.403 274.425 419.859C274.425 409.315 266.176 400.768 256 400.768C245.824 400.768 237.574 409.315 237.574 419.859C237.574 430.403 245.824 438.95 256 438.95Z" fill="black"/> | ||
| <path d="M92.1407 438.95C102.317 438.95 110.566 430.403 110.566 419.859C110.566 409.315 102.317 400.768 92.1407 400.768C81.9645 400.768 73.7151 409.315 73.7151 419.859C73.7151 430.403 81.9645 438.95 92.1407 438.95Z" fill="black"/> | ||
| <path d="M419.859 275.091C430.035 275.091 438.285 266.544 438.285 256C438.285 245.456 430.035 236.909 419.859 236.909C409.683 236.909 401.434 245.456 401.434 256C401.434 266.544 409.683 275.091 419.859 275.091Z" fill="black"/> | ||
| <path d="M92.1407 275.091C102.317 275.091 110.566 266.544 110.566 256C110.566 245.456 102.317 236.909 92.1407 236.909C81.9645 236.909 73.7151 245.456 73.7151 256C73.7151 266.544 81.9645 275.091 92.1407 275.091Z" fill="black"/> | ||
| <path d="M419.859 111.232C430.035 111.232 438.285 102.685 438.285 92.1408C438.285 81.597 430.035 73.0496 419.859 73.0496C409.683 73.0496 401.434 81.597 401.434 92.1408C401.434 102.685 409.683 111.232 419.859 111.232Z" fill="black"/> | ||
| <path d="M256 111.232C266.176 111.232 274.425 102.685 274.425 92.1408C274.425 81.597 266.176 73.0496 256 73.0496C245.824 73.0496 237.574 81.597 237.574 92.1408C237.574 102.685 245.824 111.232 256 111.232Z" fill="black"/> | ||
| <path d="M92.1407 111.232C102.317 111.232 110.566 102.685 110.566 92.1408C110.566 81.597 102.317 73.0496 92.1407 73.0496C81.9645 73.0496 73.7151 81.597 73.7151 92.1408C73.7151 102.685 81.9645 111.232 92.1407 111.232Z" fill="black"/> | ||
| <path d="M344.736 227.405H267.066V159.846C267.066 152.384 257.933 149.152 253.53 155.059L161.28 272C157.44 277.12 160.979 284.614 167.258 284.614H244.934V352.154C244.934 359.616 254.067 362.848 258.47 356.941L350.72 240C354.56 234.88 351.014 227.405 344.736 227.405Z" fill="black"/> |
There was a problem hiding this comment.
Looks like there are 8 perfect circles that could be simplified with <circle> here.
Not blocking by any means but it would make the file a bit smaller.
There was a problem hiding this comment.
Good point also the paths could be joined as there's no reason to be able to color them individually. However, I am not certain it works with our icon-sprite https://github.com/electricitymap/electricitymap-contrib/blob/e01f89daa8fef978574094333e28d411c4d80a6b/web/public/images/icon-sprite.svg?short_path=83ed875#L29
There was a problem hiding this comment.
Everything that is valid SVG should work in the sprite but I can take a look at it tomorrow if you want.
Edit: We may actually want to keep the dots as separate paths then we could animate them into a nice loading animation using animated svgs in the future. Just a thought though.
There was a problem hiding this comment.
Yeah that's a fun idea :)
|
Oh thanks for the reviewwe wanted to launch this last week but had to postpone due to sickness. Anyways, our plan is to get this live tomorrow so I'll just get this merged in :) |
Yeah there are so many places we need to change this. I've tried in this PR to change it in all the non-breaking places and then we can gradually switch it out over time on these more complex places |
We're changing our name to Electricity Maps, this is the first PR to set up the initial logo and texts.
Will share more soon on why/how we're doing the change :)