Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(JP): fix date comparison error in price parser #4347

Merged
merged 2 commits into from
Jul 16, 2022

Conversation

shuuji3
Copy link
Contributor

@shuuji3 shuuji3 commented Jul 16, 2022

resolves #4346

This is because df['Date'] column has datetime64[ns] dtype instead of datetime.date type. This change convert it to datetime.date by .dt.date attribute.

I also used Pandas' pd.to_datetime() method instead of DataFrame.apply() for code readability.

This is because `df['Date']` column has `datetime64[ns]` dtype instead of `datetime.date` type. This change convert it to `datetime.date` by `.dt.date` attribute.

I also used Pandas' `pd.to_datetime()` method instead of `DataFrame.apply()` for code readability.

resolves electricitymaps#4346
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi and Welcome!

This is a really nice fix!
I'll go ahead and merge this right away. 🎉

@shuuji3
Copy link
Contributor Author

shuuji3 commented Jul 16, 2022

@VIKTORVAV99 Thanks for taking a look!🙂 I love this project. I live in Japan and can read resources written in Japanese so I'd like to contribute more especially in Japan area if any.

@VIKTORVAV99
Copy link
Member

Hmm, the CircleCI checks don't appear to be running (and I can't merge without them...)

@Kongkille do you have any idea why?
I tried triggering them manually on CircleCI but I can't even seem to find this PR on the dashboard.

@VIKTORVAV99
Copy link
Member

@VIKTORVAV99 Thanks for taking a look!🙂 I love this project. I live in Japan and can read resources written in Japanese so I'd like to contribute more especially in Japan area if any.

Thanks for helping out, if you want something to do right away you could look over the translations, I know we recently added a few more strings to translate and I don't think we have a Japanese translation for those yet.

Otherwise I think it's the usual things like keeping the capacities updated such that's needed for now.

Only do what you can (some can take a lot of time) and feel comfortable with though, any contribution however small is appreciated!

@shuuji3
Copy link
Contributor Author

shuuji3 commented Jul 16, 2022

Thanks for your advice. I can update the Japanese translation.

@VIKTORVAV99 VIKTORVAV99 enabled auto-merge (squash) July 16, 2022 14:14
@VIKTORVAV99 VIKTORVAV99 merged commit 60dc41e into electricitymaps:master Jul 16, 2022
@shuuji3 shuuji3 deleted the fix-jp-parser-warning branch July 16, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JP: fix "No recent data found for price parser" error
2 participants