fix(JP-TK): fix "No recent data found for consumptionForecast parser" warning #4350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TEPCO's public CSV data URL has been updated twice everytime its spec changed. 1. http://www.tepco.co.jp/forecast/html/images/juyo-j.csv 2. http://www.tepco.co.jp/forecast/html/images/juyo-d-j.csv 3. http://www.tepco.co.jp/forecast/html/images/juyo-d1-j.csv Current consumption forcast fetch uses the first one and it seems that the company stopped to update at least the consumption forcast in the old CSVs. It always returns `0` as a forcast This PR changes to use he latest one, which is always updated now.
VIKTORVAV99
approved these changes
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEPCO's public CSV data URL has been updated twice in the past every time its spec changed.
The current parser function for consumption forecast uses the first one and it seems that the company stopped updating at least the consumption forcast in the old CSVs. Those CSVs always return
0as forcast.This PR changes to use he latest one, which is always updated now.