Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KR): correct the price value unit from Won/kWh to Won/MWh #4354

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

shuuji3
Copy link
Contributor

@shuuji3 shuuji3 commented Jul 18, 2022

resolves #4084

The data source (https://new.kpx.or.kr/smpInland.es?mid=a10606080100&device=pc) shows the value as Won/KWh but the parser treated it as Won/MWh.

@shuuji3
Copy link
Contributor Author

shuuji3 commented Jul 18, 2022

I'll fix the format error later.

@VIKTORVAV99
Copy link
Member

Nice fix. This should be ready to merge when the formatting is done.

The data source (new.kpx.or.kr/smpInland.es?mid=a10606080100&device=pc) shows the value as Won/KWh but the parser treated it as Won/MWh.
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@VIKTORVAV99 VIKTORVAV99 enabled auto-merge (squash) July 18, 2022 22:16
@shuuji3
Copy link
Contributor Author

shuuji3 commented Jul 18, 2022

OK, I applied black formatting.

@shuuji3
Copy link
Contributor Author

shuuji3 commented Jul 18, 2022

Thanks!

@VIKTORVAV99 VIKTORVAV99 merged commit cc90ea2 into electricitymaps:master Jul 19, 2022
@shuuji3 shuuji3 deleted the kr/fix-wrong-price-value branch July 19, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

South Korean electricity price is off by a factor of 1000x
2 participants