Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider triggers on drop event in Firefox #6487

Open
basetian opened this issue Feb 15, 2024 · 4 comments
Open

Slider triggers on drop event in Firefox #6487

basetian opened this issue Feb 15, 2024 · 4 comments

Comments

@basetian
Copy link

Describe the bug
In Firefox the view changes depending on where you drop the slider. If you slide it past the end of the scale at the end it will select the country where you dropped the slider or the overview if you drop it on the ocean

To Reproduce
Steps to reproduce the behavior:
Drag the time slider and drop it either on an ocean on the map or another button (i.e. "12 month")

Video
https://imgur.com/a/oBp7mpz

Desktop (if relevant):

  • OS: Windows 11
  • Browser: Stock Firefox
  • Version 121

Additional context
Doesn't seem to happen in Edge or Chrome

@AlisCode
Copy link
Contributor

AlisCode commented Mar 6, 2024

I've investigated this a bit, it looks like this is a bug with every radix-ui slider (not specific to electricitymaps' TimeSlider). The same buggy behaviour can be reproduced on their demo page for the slider, see here : https://www.radix-ui.com/primitives/docs/components/slider

Notice how if you drag the slider and release over the button to "open in CodeSandbox", the same problem arises. This is not a problem on Chromium indeed.

Whether this is a @radix-ui/react-slider or a Firefox issue is unclear to me btw. I think the most reasonable course of action here is to open an issue on radix-ui's side ?

@VIKTORVAV99
Copy link
Member

I would suggest opening a issue with radix-ui itself I would suggest opening a issue with them (and link it in here) as there is not much we can do if it's a issue in the package.

Please double check if there is already an issue open though.

@AlisCode
Copy link
Contributor

@VIKTORVAV99, Hello, I have opened radix-ui/primitives#2777 on radix-ui/primitives. I've tried to come up with a solution on my own, or at least a workaround (a patch to be applied on react-slider) but to no avail, yet. Will report back here if anything new happens.

@VIKTORVAV99
Copy link
Member

@VIKTORVAV99, Hello, I have opened radix-ui/primitives#2777 on radix-ui/primitives. I've tried to come up with a solution on my own, or at least a workaround (a patch to be applied on react-slider) but to no avail, yet. Will report back here if anything new happens.

Thanks, will watch the issue and see what they say!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants