New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove arrow NG.py #6696
remove arrow NG.py #6696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi and welcome to the Electricity Contrib repository.
Thanks for creating a PR for this.
I have a small comment with a suggestion but besides that this looks good!
Co-authored-by: Viktor Andersson <30777521+VIKTORVAV99@users.noreply.github.com>
Is there anything else I need to do? |
Nope, I just missed that this PR had been updated. In the future feel free to re-request a review then it will show up as an action needed from my side. 🙂 |
If possible, please review it quick. If this pull request is being accepted, I can get extra credits for my course, which is going to end. And thanks for the help you have provided so far!! I really appreciate it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for doing this!
Issue
Description
remove arrow usage from NG.py
Preview
Double check
poetry run test_parser "zone_key"
pnpx prettier@2 --write .
andpoetry run format
in the top level directory to format my changes.