Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove arrow NG.py #6696

Merged
merged 4 commits into from May 2, 2024
Merged

Conversation

lin0110
Copy link
Contributor

@lin0110 lin0110 commented Apr 26, 2024

Issue

Description

remove arrow usage from NG.py

Preview

Double check

  • [O] I have tested my parser changes locally with poetry run test_parser "zone_key"
  • [O] I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@github-actions github-actions bot added parser python Pull requests that update Python code labels Apr 26, 2024
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi and welcome to the Electricity Contrib repository.

Thanks for creating a PR for this.
I have a small comment with a suggestion but besides that this looks good!

parsers/NG.py Outdated Show resolved Hide resolved
lin0110 and others added 2 commits April 29, 2024 08:39
Co-authored-by: Viktor Andersson <30777521+VIKTORVAV99@users.noreply.github.com>
@lin0110
Copy link
Contributor Author

lin0110 commented Apr 30, 2024

Is there anything else I need to do?

@VIKTORVAV99 VIKTORVAV99 self-requested a review April 30, 2024 12:48
@VIKTORVAV99
Copy link
Member

Is there anything else I need to do?

Nope, I just missed that this PR had been updated. In the future feel free to re-request a review then it will show up as an action needed from my side. 🙂

@lin0110
Copy link
Contributor Author

lin0110 commented May 2, 2024

If possible, please review it quick. If this pull request is being accepted, I can get extra credits for my course, which is going to end. And thanks for the help you have provided so far!! I really appreciate it!

Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for doing this!

@VIKTORVAV99 VIKTORVAV99 merged commit c974e8b into electricitymaps:master May 2, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants