New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WavPlayer digital clicks/playback issues #535
Comments
@stephenhensley hello! reporting back on this: i've seemed to fix the problem by setting the buffer array as a global object with the
and by modifying the it doesn't seem like the attribute can be added directly on the class property buffer would it be a good idea to start a pull request to address this bug with my fix? i could also change the |
Hey @netherwaves this is a really interesting update. Thanks for sharing When the buffer was internal to the WavPlayer, what memory section did you have it in? I'm generally a fan of portable buffers within libDaisy to changing sizes, and using other sections without having to have the object's logic data in the other memory. So I'd be open to a PR to change this. However, it does make me wonder if there's some issue with the classes use of that buffer possibly overflowing beyond the size of the buffer or something. |
ah! so you mean it would be an idea to try something like this then:
this isn't something i had thought of, and yes you're right, it's been declared globally all this time, since i've been using the DaisyExamples entry as a boilerplate. although i just tried it and it doesn't fix the problem... if anything, the clicks are now even louder and steady than before :p dismembering the buffer itself is still what seems to work best for me |
Same trouble here, I tried the workarounds mentioned above, also putting WavPlayer into the SDRAM (DSY_SDRAM_BSS). No luck this far. |
+1. Is this issue being addressed to, it seems awfully quiet here? |
@netherwaves would you mind sharing your code on his? I don't fully understand how you passed/used the array in sdramm? |
@VorkHeftruck here's a gist with a modded version of the WavPlayer class (located at you'll have to recompile the library in order for the change to apply! |
@netherwaves thanks for the code, very insightful! I've tried it locally (I changed it a bit to work outside of the library). I understand what you meant in previous messages, now. You pass the SDRAM buffer as a pointer to the Init. The other changes you made are very similar to my own. However the clicks and digital artifacts are still there... Way less. But still... |
Reported on the forum; seems like something to do with
Prepare
is causing audio to be held up, and interferes with the callback in general.This was demonstrated by generating a low freq. oscillator tone while running the
WavPlayer
and hearing some digital artifacts.The text was updated successfully, but these errors were encountered: