Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.13 related (maybe) bug #1570

Closed
doortts opened this issue May 25, 2018 · 8 comments
Closed

v0.13 related (maybe) bug #1570

doortts opened this issue May 25, 2018 · 8 comments

Comments

@doortts
Copy link

doortts commented May 25, 2018

First, thank you for your newly released version. : )
I've waited dependency updated version.

BTW, I tried it very clean cloning and following steps as described in README

yarn
yarn dev

But unfortunatley, it is failed.

image

console log

yarn dev              1.8m  Fri May 25 10:35:45 2018
yarn dev v0.24.6
$ cross-env START_HOT=1 node -r babel-register ./internals/scripts/CheckPortInUse.js && cross-env START_HOT=1 npm run start-renderer-dev

> electron-react-boilerplate@0.13.3 start-renderer-dev /Users/doortts/repos/electron-react-boilerplate
> cross-env NODE_ENV=development node --trace-warnings -r babel-register ./node_modules/webpack-dev-server/bin/webpack-dev-server --config webpack.config.renderer.dev.js

Starting Main Process...

> electron-react-boilerplate@0.13.3 start-main-dev /Users/doortts/repos/electron-react-boilerplate
> cross-env HOT=1 NODE_ENV=development electron -r babel-register ./app/main.dev.js

[91249:0525/103605.437925:ERROR:CONSOLE(0)] "Failed to load https://chrome-devtools-frontend.appspot.com/serve_file/@7accc8730b0f99b5e7c0702ea89d1fa7c17bfe33/product_registry_impl/product_registry_impl_module.js: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'chrome-devtools://devtools' is therefore not allowed access. The response had HTTP status code 404.", source: chrome-devtools://devtools/bundled/inspector.html?remoteBase=https://chrome-devtools-frontend.appspot.com/serve_file/@7accc8730b0f99b5e7c0702ea89d1fa7c17bfe33/&can_dock=true&toolbarColor=rgba(223,223,223,1)&textColor=rgba(0,0,0,1)&experiments=true (0)
[91249:0525/103605.438022:ERROR:CONSOLE(22)] "Empty response arrived for script 'https://chrome-devtools-frontend.appspot.com/serve_file/@7accc8730b0f99b5e7c0702ea89d1fa7c17bfe33/product_registry_impl/product_registry_impl_module.js'", source: chrome-devtools://devtools/bundled/inspector.js (22)
[91249:0525/103605.438501:ERROR:CONSOLE(105)] "Uncaught (in promise) Error: Could not instantiate: ProductRegistryImpl.Registry", source: chrome-devtools://devtools/bundled/inspector.js (105)
[91249:0525/103605.438564:ERROR:CONSOLE(105)] "Uncaught (in promise) Error: Could not instantiate: ProductRegistryImpl.Registry", source: chrome-devtools://devtools/bundled/inspector.js (105)
[91249:0525/103605.438604:ERROR:CONSOLE(105)] "Uncaught (in promise) Error: Could not instantiate: ProductRegistryImpl.Registry", source: chrome-devtools://devtools/bundled/inspector.js (105)
[91249:0525/103605.438639:ERROR:CONSOLE(105)] "Uncaught (in promise) Error: Could not instantiate: ProductRegistryImpl.Registry", source: chrome-devtools://devtools/bundled/inspector.js (105)
2018-05-25 10:36:11.351 Electron Helper[91254:3822492] Couldn't set selectedTextBackgroundColor from default ()

devtools log

VM114:2 Uncaught TypeError: Cannot read property 'state' of undefined
    at unliftState (<anonymous>:2:31678)
    at getState (<anonymous>:2:31745)
    at redux-logger.js:1
    at Object.eval [as dispatch] (index.js:14)
    at Object.dispatch (<anonymous>:2:1620)
    at ProxyComponent.ConnectedRouter._this.handleLocationChange (ConnectedRouter.js:33)
    at ProxyComponent.componentWillMount (ConnectedRouter.js:47)
    at callComponentWillMount (react-dom.development.js:11393)
    at mountClassInstance (react-dom.development.js:11476)
    at updateClassComponent (react-dom.development.js:13037)

image

@Widus
Copy link

Widus commented May 25, 2018

I can see a same bug too. Only 'npm run dev' is not work. 'npm run package' is work.

@Widus
Copy link

Widus commented May 25, 2018

This bug is related with redux devtools.
----> configureStore.dev.js - window.REDUX_DEVTOOLS_EXTENSION

When I change this dev store to production store, it works fine.

@amilajack
Copy link
Member

Ahh yes, the devtools need to be updated: See https://github.com/chentsulin/electron-react-boilerplate/wiki/DevTools#devtools-extension

$ UPGRADE_EXTENSIONS=1 npm run dev

# For Windows
$ set UPGRADE_EXTENSIONS=1 && npm run dev

@amilajack
Copy link
Member

@doortts Did you resolve this?

@doortts
Copy link
Author

doortts commented May 30, 2018

@amilajack Unfortunately it doesn't work for me.
Do you think it is a problem which is related with devtron?
See: electron-userland/devtron#109

It doesn't work in dev mode.

@aguynamedben
Copy link

I was having the same problem on v0.13 and UPGRADE_EXTENSIONS=1 yarn dev fixed it 👍

@doortts
Copy link
Author

doortts commented Jun 18, 2018

@amilajack @aguynamedben It works! Thanks! BTW, what is the 'UPGRADE_EXTENSIONS=1' ?

@stevenkkim
Copy link

stevenkkim commented Feb 22, 2019

This bug is related with redux devtools.
----> configureStore.dev.js - window.REDUX_DEVTOOLS_EXTENSION

When I change this dev store to production store, it works fine.

This worked for me, thank you very much.

To clarify, I edited the file app/store/configureStore.dev.js and replaced instances of
window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__
with
window.REDUX_DEVTOOLS_EXTENSION

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants