Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add CONTRIBUTING.md #1892

Closed
amilajack opened this issue Oct 29, 2018 · 2 comments
Closed

PR: Add CONTRIBUTING.md #1892

amilajack opened this issue Oct 29, 2018 · 2 comments
Assignees
Labels

Comments

@amilajack
Copy link
Member

amilajack commented Oct 29, 2018

The goal with this is to make it easier for new contributors to PR to ERB. We should denote our conventions:

  • PR'ing to the next branch
  • Using yarn
  • Use descriptive messages for PR headings and commit messages
  • Denote the standards for RFCs. We can model this after Rust's RFCs
  • Update CHANGELOG.md
@amilajack amilajack self-assigned this Oct 30, 2018
@vikr01
Copy link
Contributor

vikr01 commented Dec 4, 2018

  • Document [skip ci] for README changes.

This is supported by appveyor and by travis.

@stale
Copy link

stale bot commented Feb 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 3, 2019
@stale stale bot closed this as completed Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants