Skip to content
This repository has been archived by the owner on Jun 5, 2019. It is now read-only.

lint task does not appear to work for the TypeScript templated projects #29

Closed
3 tasks done
nelsonjchen opened this issue Apr 19, 2017 · 3 comments
Closed
3 tasks done

Comments

@nelsonjchen
Copy link

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:

It doesn't appear the lint task work in the generated projects. For example, right away there's an issue with the curly rule warning not popping up for src/index.ts.

Please provide either a failing minimal testcase (with a link to the code) or detailed steps to
reproduce your problem.

Run this:

electron-forge init foobar-project --template=react-typescript

Now open foobar-project/src/index.ts in something that's tslint aware like VS Code. You'll immediate see there's a linting error on about line 11, where there's no curly braces for the live reload check. That is, by the way, a separate issue.

Now run yarn lint or anything that runs the lint task. No lint warnings appears. If you go into either of the tsx or ts files and start putting stuff in them clearly out of style, the lint task will give no warnings. In fact, you can replace index.ts with the US constitution or anything that's not valid code and it won't be read either.

I think the issue is that the lint task resolves to tslint src and that does not appear to recursively lint .ts or .tsx files undernearth src. Running something explicit like yarn lint -- src/index.ts does get the linter to respond to the file on disk.

@nelsonjchen
Copy link
Author

While #31 resolves the react-typescript situation, as mentioned in #31, another PR should be made against the angular 2 version too.

@malept malept changed the title lint task does not appear to work for react-typescript template and maybe the other Typescript templated projects lint task does not appear to work for the TypeScript templated projects Apr 26, 2017
@malept
Copy link
Member

malept commented Apr 26, 2017

It would be most helpful if someone more familiar with Angular 2 could make the PR.

@malept
Copy link
Member

malept commented Jun 4, 2019

Closing, see #66

@malept malept closed this as completed Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants