fix(core): stop specs hanging due to pending process.stdin listener

electron · May 14, 2018 · b747c99 · b747c99
1 parent 987161e
commit b747c99
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/packages/api/core/src/api/start.ts b/packages/api/core/src/api/start.ts
@@ -106,14 +106,16 @@ export default async ({
     return spawned;
   };
 
-  process.stdin.on('data', (data) => {
-    if (data.toString().trim() === 'rs' && lastSpawned) {
-      console.info('\nRestarting App\n'.cyan);
-      (lastSpawned as any).restarted = true;
-      lastSpawned.kill('SIGTERM');
-      forgeSpawnWrapper();
-    }
-  });
+  if (interactive) {
+    process.stdin.on('data', (data) => {
+      if (data.toString().trim() === 'rs' && lastSpawned) {
+        console.info('\nRestarting App\n'.cyan);
+        (lastSpawned as any).restarted = true;
+        lastSpawned.kill('SIGTERM');
+        forgeSpawnWrapper();
+      }
+    });
+  }
 
   return forgeSpawnWrapper();
 };
diff --git a/packages/api/core/test/fast/start_spec.ts b/packages/api/core/test/fast/start_spec.ts
@@ -12,6 +12,7 @@ describe('start', () => {
   let resolveStub: SinonStub;
   let spawnStub: SinonStub;
   let shouldOverride: boolean;
+  let processOn: SinonStub;
 
   beforeEach(() => {
     resolveStub = sinon.stub();
@@ -34,6 +35,11 @@ describe('start', () => {
         spawn: spawnStub,
       },
     }).default;
+    processOn = sinon.stub(process.stdin, 'on');
+  });
+
+  afterEach(() => {
+    processOn.restore();
   });
 
   it('should spawn electron in the correct dir', async () => {