Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect potentially troublesome npm/yarn versions and warn users #269

Closed
MarshallOfSound opened this issue Jul 21, 2017 · 1 comment
Closed

Detect potentially troublesome npm/yarn versions and warn users #269

MarshallOfSound opened this issue Jul 21, 2017 · 1 comment
Labels
enhancement

Comments

@MarshallOfSound
Copy link
Member

Some versions of npm and yarn do not work very well especially when it comes to prune --production. We should be nice and warn users

Closes #265
This was referenced Jul 23, 2017
Closed
Closed
@MarshallOfSound
Copy link
Member Author

For issues like electron-userland/electron-forge-templates#45 we should look into launching electron-prebuilt-compile from the module's bin directory instead of the resolved electron executable in the .bin folder, their appears to be a race condition in npm@5 where the prebuilt compile binary is overwritten by the normal electron one

@MarshallOfSound MarshallOfSound mentioned this issue Jul 24, 2017
Merged
5 tasks
malept added a commit that referenced this issue Jul 31, 2017
@malept
feat(generic): print a warning if the package manager used is not a k…
4d1a9f3 
…nown good version

ISSUES CLOSED: #269
@malept malept mentioned this issue Jul 31, 2017
Merged
5 tasks
malept added a commit that referenced this issue Jul 31, 2017
@malept
feat(generic): print a warning if the package manager used is not a k…
11e47c5 
…nown good version

ISSUES CLOSED: #269
malept added a commit that referenced this issue Jul 31, 2017
@malept
feat(generic): print a warning if the package manager used is not a k…
e3b0f8d 
…nown good version

ISSUES CLOSED: #269
@MarshallOfSound MarshallOfSound mentioned this issue Jul 31, 2017
Closed
malept added a commit that referenced this issue Aug 6, 2017
@malept
feat(generic): print a warning if the package manager used is not a k…
4a09596 
…nown good version

ISSUES CLOSED: #269
malept added a commit that referenced this issue Aug 6, 2017
@malept
feat(generic): print a warning if the package manager used is not a k…
a4c36fa 
…nown good version

ISSUES CLOSED: #269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MarshallOfSound