Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Use the preinstalled yarn on AppVeyor #146

Merged
merged 6 commits into from Feb 23, 2017
Merged

fix(ci): Use the preinstalled yarn on AppVeyor #146

merged 6 commits into from Feb 23, 2017

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Feb 23, 2017 •
edited

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

@malept
Copy link
Member

malept commented Feb 23, 2017

Seems dangerous 😰 (Also, it didn't work 😄)

Can we use stable yarn yet?

@MarshallOfSound
Copy link
Member Author

@malept This is latest stable 👍

Didn't work because I was silly 😆

@malept
Copy link
Member

malept commented Feb 23, 2017

Ah, when I read "latest yarn" I immediately assumed it was the latest nightly.

@malept malept changed the title fix(ci): Use the latest yarn download URL fix(ci): Use the preinstalled yarn on AppVeyor Feb 23, 2017
@malept
Copy link
Member

malept commented Feb 23, 2017

Renamed issue to be more accurate 😄

malept
malept approved these changes Feb 23, 2017
View reviewed changes
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: squash & merge away

@MarshallOfSound MarshallOfSound merged commit 7a1deee into master Feb 23, 2017
@MarshallOfSound MarshallOfSound deleted the MarshallOfSound-patch-2 branch February 23, 2017 23:03
dsanders11 pushed a commit that referenced this pull request Jan 14, 2023
@felixrieseberg
Merge pull request #146 from electron/use-classnames
f8b5187 
refactor: Use classnames module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malept malept malept approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarshallOfSound @malept