feat(starter): provide an executable to start forge in a vscode debugger compatible way #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger compatible way Currently only on darwin and linux, win32 implemenation to come
|
Yay! Looks like the checks are failing though… |
malept
requested changes
Apr 17, 2017
README.md
Outdated
| easy with Forge. Simply add this as a launch config in VSCode and you're | ||
| good to go. | ||
|
|
||
| ```json |
There was a problem hiding this comment.
Might want to change this to javascript since comments aren't a thing 😄
src/electron-forge-start.js
Outdated
| @@ -47,6 +48,13 @@ import { start } from './api'; | |||
| runAsNode: !!program.runAsNode, | |||
| }; | |||
|
|
|||
| if (program.vscode && appArgs) { | |||
| appArgs = appArgs | |||
| // Args are in the format ~arg~ so we need to strip the "~" | |||
There was a problem hiding this comment.
Personally, I'd put the comment one line above and not split up the statement.
One of them is because of #110. |
|
@malept Hmmm ok, when will this be merged? |
|
Once the requested changes are addressed? 😄 |
|
Is there a way for me to make the changes? |
|
You could make a pull request on this pull request branch (instead of master). |
5 tasks
MarshallOfSound
force-pushed
the
vscode-debug
branch
from
8d3f8a9
to
8164d3e
Compare
malept
approved these changes
Apr 17, 2017
|
NPM release? |
|
I should have a minute before your comment. Did it not publish correctly? |
|
Sorry, it’s working now 😉 |
dsanders11
pushed a commit
that referenced
this pull request
Jan 14, 2023
feat: Update all dependencies (Electron 5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only on Darwin and Linux, win32 implementation to come
Summarize your changes:
Basically adds a new binary to target with VS Code that mangles the args so we can pass node debug args through node without them making the forge host process enter debugging mode. 😆