feat(maker): add support for Windows Store (appx) packages #43
Conversation
| deploy: false, | ||
| packageVersion: `${packageJSON.version}.0`, | ||
| packageName: packageJSON.name, | ||
| packageDisplayName: packageJSON.name, |
There was a problem hiding this comment.
This should probably be appName (Which defaults to packageJSON.productName) to be consistent with the other makers
| packageName: packageJSON.name, | ||
| packageDisplayName: packageJSON.name, | ||
| packageDescription: packageJSON.description || '', | ||
| packageExecutable: `app\\${packageJSON.name}.exe`, |
There was a problem hiding this comment.
Same, should be appName
There was a problem hiding this comment.
This is the name of the executable, is that right?
There was a problem hiding this comment.
I had to double check. But yeah.
https://github.com/electron-userland/electron-packager/blob/master/docs/api.md#name
electron-packager uses productName if it is available so the exe will use prodcutName if is there, else just name. That's why we have appName so we only have that logic in one place.
| @@ -115,6 +115,7 @@ config object: | |||
| |-------------|---------------------|-------------|----------------------|----------|--------------| | |||
| | `zip` | All | Zips your packaged application | None | Yes | `zip` on Darwin/Linux | | |||
| | `squirrel` | Windows | Generates an installer and `.nupkg` files for Squirrel.Windows | [`electronWinstallerConfig`](https://github.com/electron/windows-installer#usage) | Yes | | | |||
| | `appx` | Windows | Generates a Windows Store package | [`windowsStoreConfig`](https://github.com/felixrieseberg/electron-windows-store#programmatic-usage) | No | | | |||
There was a problem hiding this comment.
Per one of your commit messages, do we want to mention that this requires the Windows SDK?
There was a problem hiding this comment.
Nah, the error message will call it out really clearly when it falls over, and on many dev machines it will be installed anyways
There was a problem hiding this comment.
Pretty sure it's mentioned in the -windows-store docs as well 👍
malept
changed the title
anaisbetts
force-pushed
the
appx
branch
3 times, most recently
from
e4e2675
to
67fab72
Compare
This PR adds a new make type for Windows, "appx", which generates Windows Store packages ISSUES CLOSED: electron#27
|
Argh, merge commit, argh 😢 |
|
I'll squash it. I should've just ignored the warning and just rebase+merged. |
That's what I do as long as it isn't too far behind 👍 |
This PR adds a new make type for Windows, "appx", which generates Windows Store packages
TODO:
Fixes #27